Skip to content

[PWGDQ] Add QA matching derived tables AO2D outputs#15517

Closed
nivram-phy wants to merge 72 commits intoAliceO2Group:masterfrom
nivram-phy:PWGDQ-QAMatchingDerivedTable
Closed

[PWGDQ] Add QA matching derived tables AO2D outputs#15517
nivram-phy wants to merge 72 commits intoAliceO2Group:masterfrom
nivram-phy:PWGDQ-QAMatchingDerivedTable

Conversation

@nivram-phy
Copy link
Copy Markdown
Contributor

@nivram-phy nivram-phy commented Mar 25, 2026

This PR extends qaMatching.cxx to produce QA-focused AO2D tables and improves true-match indexing logic to use track-type–based muon selection. Add AOD schema and producers for QAMEVT, QAMCHTRK, and QAMCAND.

QAMEVT
Event-level summary: reduced event ID, MFT multiplicity, and collision vertex position.
QAMCHTRK
Per-MCH track info: track ID/type, kinematics, vertex-propagated params, and MFT matching attempts.
QAMCAND
Per-candidate info: matching label, parent track ID/kinematics, match type, score, and rank.

@github-actions github-actions Bot added the pwgdq label Mar 25, 2026
@github-actions github-actions Bot changed the title Add QA matching derived tables AO2D outputs [PWGDQ] Add QA matching derived tables AO2D outputs Mar 25, 2026
@alibuild alibuild mentioned this pull request Mar 25, 2026
Merged
nivram-phy added a commit to nivram-phy/O2Physics that referenced this pull request Mar 25, 2026
@nivram-phy
Merge pull request #8 from alibuild/alibot-cleanup-15517
7476fb1 
Please consider the following formatting changes to AliceO2Group#15517
@nivram-phy nivram-phy marked this pull request as ready for review March 26, 2026 14:31
@ariffero
Copy link
Copy Markdown
Contributor

ariffero commented Mar 26, 2026

@ariffero Here is our pull request for your review

Hi @nivram-phy, I think that you tagged the wrong Andrea

@vkucera vkucera marked this pull request as draft March 26, 2026 16:02
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Mar 26, 2026

Error while checking build/O2Physics/o2 for 4665baf at 2026-03-26 17:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15517-slc9_x86-64/0/PWGDQ/Tasks/qaMatching.cxx:1712:17: error: unused variable 'mftTrack' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

This was referenced Mar 30, 2026
Closed
Closed
Closed
Merged
nivram-phy added a commit to nivram-phy/O2Physics that referenced this pull request Mar 30, 2026
@nivram-phy
Merge pull request #12 from alibuild/alibot-cleanup-15517
d357d9c 
Please consider the following formatting changes to AliceO2Group#15517
@nivram-phy
Copy link
Copy Markdown
Contributor Author

nivram-phy commented Mar 30, 2026

@aferrero2707 Here is the PR for AO2D files

@nivram-phy nivram-phy marked this pull request as ready for review March 31, 2026 08:40
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Mar 31, 2026

Error while checking build/O2Physics/o2 for d357d9c at 2026-03-31 10:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/qaMatching.cxx:2905:42: error: expected ')' before 'PRId64'
ninja: build stopped: subcommand failed.

Full log here.

@nivram-phy nivram-phy marked this pull request as draft March 31, 2026 08:53
@nivram-phy nivram-phy marked this pull request as ready for review March 31, 2026 09:31
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 7, 2026 •
edited
Loading

Error while checking build/O2Physics/o2 for f4a5e17 at 2026-04-08 06:43:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@aferrero2707
Copy link
Copy Markdown
Contributor

aferrero2707 commented Apr 10, 2026

@nivram-phy I am testing the code locally, will give some feedback here after the weekend.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@nivram-phy
Copy link
Copy Markdown
Contributor Author

nivram-phy commented Apr 16, 2026 •
edited
Loading

@mcoquet642 Two separate issues showed up: PWGDQ/Tasks/qaMatching.cxx is now being fully linted and fails on many pre-existing whole-file linter violations, OS violations from outside of this code
Should I do something?

@aferrero2707 Latest code with my modifications has been pushed.

vkucera
vkucera requested changes Apr 16, 2026
View reviewed changes
Comment thread PWGDQ/Tasks/qaMatching.cxx
@nivram-phy nivram-phy requested a review from vkucera April 17, 2026 10:56
@alibuild alibuild mentioned this pull request Apr 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@nzardosh nzardosh Awaiting requested review from nzardosh nzardosh is a code owner

@raymondEhlers raymondEhlers Awaiting requested review from raymondEhlers raymondEhlers is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

@amatyja amatyja Awaiting requested review from amatyja amatyja is a code owner

@rolavick rolavick Awaiting requested review from rolavick rolavick is a code owner

@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner

@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner

@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner

@wenyaCern wenyaCern Awaiting requested review from wenyaCern wenyaCern is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@SwatiSaha-1997 SwatiSaha-1997 Awaiting requested review from SwatiSaha-1997 SwatiSaha-1997 is a code owner

@isputows isputows Awaiting requested review from isputows isputows is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@lietava lietava Awaiting requested review from lietava lietava is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@njacazio njacazio Awaiting requested review from njacazio njacazio is a code owner

Assignees

No one assigned

Labels

alice3 datamodel photon Photon and neutral meson PAG label pwgcf pwgdq pwgem pwghf PWG-HF pwgje pwglf pwgud trigger

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.